-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(multiframe): metadata handling of NM studies and loading order #4540
Commits on Nov 20, 2024
-
DicomJSONDataSource, DicomLocalDataSource, DicomWebDataSource, Metada…
…taProvider: Improve multiframe handling and error checking - Corrected a typo in a comment from "necessarliy" to "necessarily" in `DicomJSONDataSource`. - Enhanced multiframe handling in `DicomLocalDataSource` and `DicomWebDataSource` by creating a separate `imageId` for each frame, ensuring proper metadata mapping for multiframe instances. - Removed usage of `instance.imageId` for multiframe instances to prevent invalid `imageId` assignments. - Added error handling in `MetadataProvider` to throw an error if `imageId` is empty during metadata operations. - Removed unnecessary comments and redundant error checks for empty `imageId` in `MetadataProvider`.
Configuration menu - View commit details
-
Copy full SHA for f429993 - Browse repository at this point
Copy the full SHA f429993View commit details
Commits on Nov 21, 2024
-
Core: Enhance frame combination logic in combineFrameInstance.ts
- Import `vec3` from 'gl-matrix' for vector operations - Refactor shared and perFrame sequences to improve readability and maintainability - Add support for calculating `ImagePositionPatient` using `ImageOrientationPatient` and `SpacingBetweenSlices` - Ensure accurate frame position calculation for NM multiframe datasets - Safeguard against undefined `ImagePositionPatient` by using calculated or default values
Configuration menu - View commit details
-
Copy full SHA for 0a5394e - Browse repository at this point
Copy the full SHA 0a5394eView commit details -
UI-Next: Simplify DataRow text rendering and enhance details section
- Removed conditional rendering for text with colons and simplified to always use a single span with font-medium class - Adjusted indentation and alignment of the Number Box for better readability and consistency - Enhanced the Details Section to include both primary and secondary details, if available - Added a muted-foreground style for secondary details to visually distinguish them from primary details
Configuration menu - View commit details
-
Copy full SHA for df5c781 - Browse repository at this point
Copy the full SHA df5c781View commit details -
Cornerstone, Preclinical-4D, TMTV: Improve null checks and update uni…
…t labels - Refactored the null check in `interleaveTopToBottom.ts` to use optional chaining for cleaner and safer access to `requests[0].imageId` - Updated the label for `meanValue` in `preclinical-4d` mode to include units "(ml)" - Updated the label for `volume` in `tmtv` mode to include units "(ml)"
Configuration menu - View commit details
-
Copy full SHA for 2ce519e - Browse repository at this point
Copy the full SHA 2ce519eView commit details -
Cornerstone: Fix slice index handling during viewport resize
- Ensure that the slice index remains unchanged during viewport resize by deleting `sliceIndex` from the presentation view reference. - This change addresses a temporary fix for a larger issue regarding the definition of slice index with slab thickness. - Plan to revisit this area to make the implementation more robust and understandable. - Adjust the `setPresentations` method to accommodate the updated position
Configuration menu - View commit details
-
Copy full SHA for ec68ddf - Browse repository at this point
Copy the full SHA ec68ddfView commit details -
Configuration menu - View commit details
-
Copy full SHA for db80066 - Browse repository at this point
Copy the full SHA db80066View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7bbfedf - Browse repository at this point
Copy the full SHA 7bbfedfView commit details -
Configuration menu - View commit details
-
Copy full SHA for f310ef3 - Browse repository at this point
Copy the full SHA f310ef3View commit details
Commits on Nov 22, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 8358e88 - Browse repository at this point
Copy the full SHA 8358e88View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9271115 - Browse repository at this point
Copy the full SHA 9271115View commit details
Commits on Nov 25, 2024
-
Cornerstone: Improve image loading and configuration options
- Updated import path for `useToggleOneUpViewportGridStore` to use `@ohif/extension-default` - Enabled interleaved image retrieval stages for volume in `index.tsx` - Registered image load strategies with metadata handling in `init.tsx` - Introduced `createMetadataWrappedStrategy` for safe metadata configuration - Added `useAppConfig` in `PanelStudyBrowserTracking` to use `studyBrowserMode` from app configuration - Updated webpack configuration to ignore certain node_modules during watch - Removed `maximumFileSizeToCacheInBytes` from PWA webpack configuration - Added `studyBrowserMode` to app configuration and documentation to set initial study browser tab
Configuration menu - View commit details
-
Copy full SHA for 7b55a95 - Browse repository at this point
Copy the full SHA 7b55a95View commit details -
UI Update: Adjust SegmentationSegments height and remove global min-h…
…eight override - Increased the default height for 'collapsed' mode in SegmentationSegments component from 600px to 900px for better user experience. - Removed the global CSS rule that set `min-height: 0 !important;` from multiple Tailwind CSS files across the platform. - The removal of the global min-height override is intended to prevent unexpected layout issues and ensure more consistent styling across components.
Configuration menu - View commit details
-
Copy full SHA for f7d9c7c - Browse repository at this point
Copy the full SHA f7d9c7cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 402fea9 - Browse repository at this point
Copy the full SHA 402fea9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 86551bb - Browse repository at this point
Copy the full SHA 86551bbView commit details
Commits on Nov 27, 2024
-
Configuration menu - View commit details
-
Copy full SHA for eed1f43 - Browse repository at this point
Copy the full SHA eed1f43View commit details -
Refactor DICOM frame handling for consistency and clarity
- Simplified frame processing logic in DicomLocalDataSource and DicomWebDataSource to handle both single and multiframe instances uniformly. - Removed redundant checks for multiframe instances, streamlining the addition of image IDs to metadata. - Enhanced the combineFrameInstance utility by improving filtering logic and optimizing vector calculations for image positioning. This update improves code readability and maintainability while ensuring consistent behavior across different DICOM data sources.
Configuration menu - View commit details
-
Copy full SHA for c0ae86e - Browse repository at this point
Copy the full SHA c0ae86eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1b15c82 - Browse repository at this point
Copy the full SHA 1b15c82View commit details -
Enhance webpack configuration and documentation
- Updated webpack.base.js to set NODE_ENV to 'production' if not already defined, improving environment handling. - Refactored writePluginImportsFile.js for better readability by formatting return statements. - Modified build-for-production.md to clarify directory navigation and removed outdated caution note regarding platform naming. These changes improve the build process and documentation clarity.
Configuration menu - View commit details
-
Copy full SHA for dae8466 - Browse repository at this point
Copy the full SHA dae8466View commit details -
Refactor webpack configuration and improve documentation
- Removed automatic setting of NODE_ENV to 'production' in webpack.base.js, allowing for more explicit environment management. - Updated babel-loader configuration to conditionally include 'react-refresh/babel' plugin based on the build mode. - Cleaned up writePluginImportsFile.js by removing unnecessary console warnings for better clarity. - Enhanced documentation in custom-url-access.md to emphasize the need for updating the public/serve.json file for new routerBasename. These changes streamline the build process and enhance documentation clarity.
Configuration menu - View commit details
-
Copy full SHA for a5b7204 - Browse repository at this point
Copy the full SHA a5b7204View commit details -
Configuration menu - View commit details
-
Copy full SHA for 543aa13 - Browse repository at this point
Copy the full SHA 543aa13View commit details