detect/bytemath: Test multiplier operator #1244
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catenacyber
reviewed
Jun 12, 2023
catenacyber
reviewed
Jun 12, 2023
|
Requires OISF/suricata#9010 |
catenacyber
requested changes
Jun 29, 2023
There was a problem hiding this comment.
@jlucovsky could you address the comments ?
Most important is to test for some exact value (cf problems we had with smb negotiate flags where the test was green because wa gad one chance out of 2 to have the right boolean value by picking it at an arbitrary offset)
catenacyber
reviewed
Aug 30, 2023
Good point ... I've modified the rule to look for an exact match. |
Issue: 6070 This commit adds a test for the byte-math multiplication operator. The operator was missing from 6.0.x; however, this test applies to 6.0.x and later once the Suricata PR is merged.
catenacyber
approved these changes
Sep 3, 2023
Closed
Closed
jasonish
approved these changes
Sep 28, 2023
Merged
|
Merged in #1244, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: 6070
This commit adds a test for the byte-math multiplication operator. The operator was missing from 6.0.x; however, this test applies to 6.0.x and later once the Suricata PR is merged.