Adds a test about flow.pkts_toclient keyword #1267
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 22, 2023
jufajardini
requested changes
Jun 23, 2023
tests/detect-flow-pkts/README.md
Outdated
| Test | ||
| ==== | ||
|
|
||
| Test `flow.pkts_toclient` keyword |
There was a problem hiding this comment.
I think it's good to list the other words that are being tested :P
There was a problem hiding this comment.
Just force-pushed a new version, is it ok ?
catenacyber
force-pushed
the
detect-flow-pkts-6164-v2
branch
from
0908b08 to
54d09c3
Compare
jufajardini
approved these changes
Jun 26, 2023
catenacyber
force-pushed
the
detect-flow-pkts-6164-v2
branch
from
54d09c3 to
13e4851
Compare
And the similar keywords about packets and bytes of a flow
catenacyber
force-pushed
the
detect-flow-pkts-6164-v2
branch
from
13e4851 to
cfe6e05
Compare
|
Merged in #1468, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Redmine ticket: https://redmine.openinfosecfoundation.org/issues/6164
Modifies #1261 with more keywords tested