Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dhcp: Validate dhcp option 60 is being logged #1359

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions tests/dhcp-eve-extended-option-60/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
# Test Description

Valide that dhcp option 60 (vendor class identifier) is being logged by suricata
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super nit: Typo Valide


## PCAP

Extracted a single packet from a pcap that had the vendor-class-id option present

## Related issues
[Feature 4587](https://redmine.openinfosecfoundation.org/issues/4587)

Binary file added tests/dhcp-eve-extended-option-60/input.pcap
Binary file not shown.
41 changes: 41 additions & 0 deletions tests/dhcp-eve-extended-option-60/test.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
requires:
min-version: 7

args:
- -k none --set outputs.1.eve-log.types.21.dhcp.extended=yes

checks:
- filter:
count: 1
match:
dest_port: 67
dhcp.id: 3759982360
dhcp.params[0]: subnet_mask
dhcp.params[1]: domain
dhcp.params[2]: router
dhcp.params[3]: dns_server
dhcp.type: request
dhcp.vendor_class_identifier: MSFT 5.0
event_type: dhcp
pcap_cnt: 1
proto: UDP
src_ip: 0.0.0.0
src_port: 68
- filter:
count: 1
match:
app_proto: dhcp
dest_ip: 255.255.255.255
dest_port: 67
event_type: flow
flow.age: 0
flow.alerted: false
flow.bytes_toclient: 0
flow.bytes_toserver: 356
flow.pkts_toclient: 0
flow.pkts_toserver: 1
flow.reason: shutdown
flow.state: new
proto: UDP
src_ip: 0.0.0.0
src_port: 68