dhcp: Validate dhcp option 60 is being logged #1362
Conversation
| min-version: 7 | ||
|
|
||
| args: | ||
| - -k none --set outputs.1.eve-log.types.21.dhcp.extended=yes |
There was a problem hiding this comment.
@jasonish will it always be 21 ?
Or should rather a minimal suricata.yaml be used here ?
There was a problem hiding this comment.
I'd rather a minimal YAML. We do have existing tests digging into arrays like this, but it is fragile. @yatink Could you update this test to provide a minimal YAML file instead of the --set?
There was a problem hiding this comment.
Sure, I can read the docs and figure out how to add that. I'll ask here if I have questions.
There was a problem hiding this comment.
Look out for other Suricata Verify tests having a suricata.yaml in their directory
There was a problem hiding this comment.
One such possible example: https://github.com/OISF/suricata-verify/blob/master/tests/bug-5802/suricata.yaml :)
There was a problem hiding this comment.
Ok done....I'll squash my changes and open a new PR.
|
Continued in #1367 |
Feature 4587
..continuation of #1361
This PR adds a test to validate that dhcp option 60 is being logged in dhcp extended logging mode.
Associated suricata PR : OISF/suricata#9397
Redmine ticket: https://redmine.openinfosecfoundation.org/issues/4587