Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: add tests for smb.version keyword v3 #1380

Closed
wants to merge 4 commits into from
Closed

tests: add tests for smb.version keyword v3 #1380

wants to merge 4 commits into from

Conversation

jmtaylor90
Copy link
Contributor

Ticket

If your pull request is related to a Suricata ticket, please provide
the full URL to the ticket here so this pull request can monitor
changes to the ticket status:

Redmine ticket:
https://redmine.openinfosecfoundation.org/issues/5075

@jmtaylor90
Copy link
Contributor Author

  • Added pcap origination information
  • Included original author commits

@jmtaylor90 jmtaylor90 mentioned this pull request Sep 6, 2023
Closed
@jufajardini jufajardini added the requires suricata pr Depends on a PR in Suricata label Sep 7, 2023
@jufajardini
Copy link
Contributor

Current Suricata PR: OISF/suricata#9451

This PR per se looks good to me, but as it seems that the Suri PR's checks have not picked this PR, I'll wait for the next PR version there to check for the CI results, then come back to this :)

@jmtaylor90 jmtaylor90 force-pushed the smb-version-keyword-tests-v3 branch from 31a6e29 to 7750c8d Compare November 29, 2023 12:05
catenacyber
catenacyber reviewed Nov 29, 2023
View reviewed changes
tests/smb-version-keyword-invalid/test.yaml Outdated
@@ -0,0 +1,14 @@
requires:
min-version: 7
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make it 8

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it okay to force push that update or should I make a new PR?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me it is ok, but maybe better to do a new PR ;-)

Copy link
Contributor Author

@jmtaylor90 jmtaylor90 Nov 29, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated this PR, if a new PR is needed I will do that

@jmtaylor90 jmtaylor90 force-pushed the smb-version-keyword-tests-v3 branch from 29a0699 to 446711d Compare December 7, 2023 17:52
@jmtaylor90 jmtaylor90 force-pushed the smb-version-keyword-tests-v3 branch from 446711d to 949eb16 Compare December 11, 2023 17:01
@catenacyber
Copy link
Collaborator

@jmtaylor90 did you just rebase and force-push ? for OISF/suricata#10027 CI to be green ?
(or were there other changes ?)

@jmtaylor90
Copy link
Contributor Author

jmtaylor90 commented Dec 12, 2023 •
edited
Loading

@jmtaylor90 did you just rebase and force-push ? for OISF/suricata#10027 CI to be green ?
(or were there other changes ?)

Yeah, was just a rebase and force push, no other changes for the latest PR

@victorjulien victorjulien mentioned this pull request Jan 19, 2024
Merged
@victorjulien
Copy link
Member

Merged in #1593, thanks!

@jmtaylor90 jmtaylor90 deleted the smb-version-keyword-tests-v3 branch January 29, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@catenacyber catenacyber catenacyber left review comments

@victorjulien victorjulien victorjulien approved these changes

Assignees
No one assigned
Labels
requires suricata pr Depends on a PR in Suricata
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jmtaylor90 @jufajardini @catenacyber @victorjulien @zer1t0