Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stats: add checks for drop reason counters - v3 #1406

Closed
wants to merge 1 commit into from

Conversation

jufajardini
Copy link
Contributor

Previous PR: #1376

Changes from last PR:

  • rebase
  • Leaving checks for stream reassembly aside as those were already added by another commit.

Leaving checks for stream reassembly aside as those were already added
by another commit.
@jufajardini jufajardini changed the title stats: add checks for drop reason counters stats: add checks for drop reason counters - v3 Oct 3, 2023
@catenacyber
Copy link
Collaborator

Is there a redmine ticket for this ?
Is it just to enhance the existing tests with more checks ?
(Should it be labelled tests pass ? )

@jufajardini
Copy link
Contributor Author

Is there a redmine ticket for this ?

Added one: https://redmine.openinfosecfoundation.org/issues/6571

Is it just to enhance the existing tests with more checks ?

Was to add checks for the recently-ish introduced drop_reason counters (https://redmine.openinfosecfoundation.org/issues/6230)

(Should it be labelled tests pass ? )

Likely, though I think I'll rebase now, and also add a ticket number to the commit message, I guess...

@jufajardini
Copy link
Contributor Author

Rebased with #1492

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants