Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: add JA4 test cases -- v3 #1411

Closed
wants to merge 1 commit into from
Closed

tests: add JA4 test cases -- v3 #1411

wants to merge 1 commit into from

Conversation

satta
Copy link
Contributor

@satta satta commented Oct 5, 2023 •
edited
Loading

Previous PR: #1408

This PR introduces test cases for TLS and QUIC JA4 calculation.

Changes:

  • Fix typo in explanatory README.
  • Rebase to current master and squash commits.

Ticket

Redmine ticket: https://redmine.openinfosecfoundation.org/issues/6379

@satta satta mentioned this pull request Oct 5, 2023
Closed
@catenacyber catenacyber added the requires suricata pr Depends on a PR in Suricata label Oct 5, 2023
inashivb
inashivb reviewed Oct 7, 2023
View reviewed changes
Copy link
Member

@inashivb inashivb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do these tests pass if ja4 hasn't been merged yet? 🤔

@satta satta mentioned this pull request Oct 16, 2023
Closed
@satta
Copy link
Contributor Author

satta commented Oct 16, 2023

New PR: #1426

@satta satta closed this Oct 16, 2023
@satta satta deleted the 6379-ja4-v3 branch October 16, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inashivb inashivb inashivb left review comments

Assignees
No one assigned
Labels
requires suricata pr Depends on a PR in Suricata
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@satta @inashivb @catenacyber