stateful drop on dsize sig/v4 #1778
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there a suricata PR with this ? |
hmm I just realized that I blindly added the min-version. Shouldn't have as the issue only exists on 6.0.x and the last PR I can trace was OISF/suricata#9664 |
|
So, the question is for Victor if we still want https://redmine.openinfosecfoundation.org/issues/5578 for 6... |
|
can you please set descriptive subjects in PRs? |
Tried to add something. Please check. Sorry but I don't have much idea about this. I just took your s-v PR and rebased it earlier so the tests would pass. |
|
Should this be rebased or closed ? |
Closed, I think. Didn't know there was a newer version that has already been merged. |
|
cf #1803 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
If your pull request is related to a Suricata ticket, please provide
the full URL to the ticket here so this pull request can monitor
changes to the ticket status:
Redmine ticket: https://redmine.openinfosecfoundation.org/issues/5578
Previous PR: #1424
Changes since v3: