Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: linktype_name test #1996

Closed
wants to merge 2 commits into from
Closed

tests: linktype_name test #1996

wants to merge 2 commits into from

Conversation

jlucovsky
Copy link
Contributor

Continuation of #1993

Issue: 6954

Ensure that the linktype_name is included in the alerts.

Updates:

  • Modify existing test cases to expand the range of linktype name values.
  • Remove unnecessary changes to existing tests

Ticket

If your pull request is related to a Suricata ticket, please provide
the full URL to the ticket here so this pull request can monitor
changes to the ticket status:

Redmine ticket: https://redmine.openinfosecfoundation.org/issues/6954

Suricata PR: OISF/suricata#11564

jlucovsky added 2 commits July 27, 2024 10:15
@jlucovsky
tests: linktype_name test
299542c 
Issue: 6954

Ensure that the linktype_name is included in the alerts.
@jlucovsky
test/linktype: Expand linktype_name coverage
de0fce8 
Issue: 4974

This commit extends the linktype_name validation across the existing
tests so that more linktype name values are checked:
    - C_HDLC
    - PPP
    - IPV4
    - IPV6
    - RAW
    - EN10B
    - LINUX_SLL

Some existing tests required suricata.yaml configuration to enable the
packet values to be in the alerts.
This was referenced Jul 31, 2024
Closed
Closed
@catenacyber catenacyber added the requires suricata pr Depends on a PR in Suricata label Aug 1, 2024
jufajardini
jufajardini requested changes Aug 2, 2024
View reviewed changes
Copy link
Contributor

@jufajardini jufajardini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add the ticket reference to the readme files, too?

@jlucovsky jlucovsky mentioned this pull request Aug 13, 2024
Closed
@jlucovsky
Copy link
Contributor Author

Continued in #2006

@jlucovsky jlucovsky closed this Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@catenacyber catenacyber catenacyber left review comments

@jufajardini jufajardini jufajardini requested changes

Assignees
No one assigned
Labels
requires suricata pr Depends on a PR in Suricata
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jlucovsky @jufajardini @catenacyber