-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mysql: add tests #2067
base: master
Are you sure you want to change the base?
mysql: add tests #2067
Conversation
d2a6dc1
to
b8d0533
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests mysql-query
and mysql-prepare-statement
are missing the suricata.yaml file. As the protocol isn't enabled by default, without having a suricata.yaml in the test and enabling the protocol in the eve logs, the test will fail here - this also applies to the tests that do have the suricata.yaml, but are not enabling mysql
event logs.
Could you add checks that showcase the log output, for us?
With new log additions, this is important for us not only to check that they look like expected, but also to discuss if the format needs changes :)
I'm sorry I don't get it. |
I meant something like what is seen here: https://github.com/OISF/suricata-verify/blob/master/tests/pgsql/pgsql-simple-query-rollback/test.yaml |
I have added, please check again, thx. |
cd311b7
to
cc4a275
Compare
b9156dd
to
2b4ed66
Compare
Task: #3446
Task #3446
Task #3446
2b4ed66
to
5f5682e
Compare
Ticket
If your pull request is related to a Suricata ticket, please provide
the full URL to the ticket here so this pull request can monitor
changes to the ticket status:
Redmine ticket: https://redmine.openinfosecfoundation.org/issues/3446