Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ffr: enable tests for 7.0.x #2177

Closed
wants to merge 1 commit into from
Closed

ffr: enable tests for 7.0.x #2177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 0 additions & 20 deletions tests/firewall/firewall-06-tls-sni-enforce/test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,27 +6,14 @@ args:

checks:
- filter:
min-version: 8
count: 24
match:
event_type: alert
alert.signature_id: 3
- filter:
min-version: 8
count: 24
match:
event_type: alert
- filter:
lt-version: 7
count: 26
match:
event_type: alert
alert.signature_id: 3
- filter:
lt-version: 7
count: 26
match:
event_type: alert
- filter:
min-version: 8
# check for https://redmine.openinfosecfoundation.org/issues/7350
Expand All @@ -52,17 +39,10 @@ checks:
match:
event_type: drop
- filter:
min-version: 8
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is less precise than #2179 as discussed in #2173

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is less precise than #2179 as discussed in #2173

Is that correct? I don't see discussion on this in #2173.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussion was rather in #2174

count: 0
match:
event_type: alert
pkt_src: "stream (flow timeout)"
- filter:
lt-version: 7
count: 2
match:
event_type: alert
pkt_src: "stream (flow timeout)"
- filter:
count: 1
match:
Expand Down
2 changes: 1 addition & 1 deletion tests/tls-extra-alert-engine-analysis/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@ engine analysis complementary test for tls-extra-alert.

## Related issues

None so far. State: Trying to establish what's the issue.
https://redmine.openinfosecfoundation.org/issues/7318
2 changes: 1 addition & 1 deletion tests/tls-extra-alert/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,4 @@ Internal.

## Related issues

None so far. State: Trying to establish what's the issue.
https://redmine.openinfosecfoundation.org/issues/7318
3 changes: 0 additions & 3 deletions tests/tls-extra-alert/test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
requires:
min-version: 8

args:
- -k none
- --simulate-ips
Expand Down
Loading