backport: for ticket 7199 and 7318 #2179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As these tickets impact some common tests
This was referenced Dec 11, 2024
jufajardini
reviewed
Dec 11, 2024
| count: 0 | ||
| match: | ||
| event_type: alert | ||
| pkt_src: "stream (flow timeout)" |
There was a problem hiding this comment.
no value in keeping this check?
There was a problem hiding this comment.
It is improved by checking the alerts are all wire/pcap
victorjulien
approved these changes
Dec 11, 2024
jasonish
approved these changes
Dec 11, 2024
|
Merged in #2181, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Redmine ticket:
https://redmine.openinfosecfoundation.org/issues/7407
https://redmine.openinfosecfoundation.org/issues/7368