Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source/erf-dag: compiler warnings #10149

Closed
wants to merge 1 commit into from
Closed

Conversation

sfd
Copy link
Contributor

@sfd sfd commented Jan 10, 2024

Bug: #6667.

Fix compiler warnings for function pointer parameters missing const with --enable-dag

Link to redmine ticket: 6667

Bug: OISF#6667.

Fix compiler warnings for function pointer parameters missing const with --enable-dag
@sfd sfd requested a review from victorjulien as a code owner January 10, 2024 21:36
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1dcf69b) 82.19% compared to head (171bec0) 82.19%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10149      +/-   ##
==========================================
- Coverage   82.19%   82.19%   -0.01%     
==========================================
  Files         974      974              
  Lines      271825   271825              
==========================================
- Hits       223416   223414       -2     
- Misses      48409    48411       +2     
Flag Coverage Δ
fuzzcorpus 63.01% <ø> (-0.01%) ⬇️
suricata-verify 61.41% <ø> (+<0.01%) ⬆️
unittests 62.85% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

sfd added a commit to sfd/suricata that referenced this pull request Jan 16, 2024
Bug: 6620.

Fix const warning with --enable=dag

Fix prototype clang-format errors

Master change in OISF#10149
@victorjulien victorjulien added this to the 8.0 milestone Jan 19, 2024
@victorjulien
Copy link
Member

Merged in #10204, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants