-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dns over http2 5773 v6 #10174
Closed
Closed
Dns over http2 5773 v6 #10174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ticket: 3827
by making tx parsing and creation more easily available, without needing a dns state. Dns event NotResponse is now set on the right tx, and not the one before. Also debug log for Z-flag on request says "request" instead of "response" Also rustfmt dns.rs
Ticket: 5773
Ticket: 5773
Ticket: 5773
Now a flow alproto can be changed by a call to AppLayerParserParse when HTTP2 forces the flow to turn into DOH2.
catenacyber
force-pushed
the
dns-over-http2-5773-v6
branch
from
January 16, 2024 14:15
2d199e4
to
b43b2cd
Compare
CI is red/SV is failing because OISF/suricata-verify#1490 is missing in OISF/suricata-verify#1573 |
Information: ERROR: QA failed on SURI_TLPW2_autofp_suri_time.
Pipeline 17557 |
This was referenced Mar 28, 2024
Rebased in #10733 |
This was referenced Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/5773
Describe changes:
OISF/suricata-verify#1573
Draft to get feedback about approach...
Leaving comments on the code for specific questions
#10125 rebased on top of #10166 (and thus getting rid of output-json-doh2.c)
TODO :
Functionnaly, in terms of output :
doh2
as app_proto (andhttp2
asapp_proto_orig
)doh2
events that have both http2 and dns fields. dns logging is done like alerts, not like dns events...Memory management
API