Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log/sguil: Issue deprecation notice if sguil mode #10195

Closed
wants to merge 1 commit into from

Conversation

jlucovsky
Copy link
Contributor

Continuation of #10180

Sguil mode will not be supported with pcap logging in 8. Flag usages of it with a deprecation notice.

Link to redmine ticket: 6688

Describe changes:

  • Issue deprecation mode if pcap logging is enabled with sguil mode

Updates:

  • Removed superfluous commit.

Provide values to any of the below to override the defaults.

To use a pull request use a branch name like pr/N where N is the
pull request number.

Alternatively, SV_BRANCH may also be a link to an
OISF/suricata-verify pull-request.

SV_REPO=
SV_BRANCH=
SU_REPO=
SU_BRANCH=
LIBHTP_REPO=
LIBHTP_BRANCH=

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (f2e83e4) 82.42% compared to head (8b0fe5e) 82.36%.

Additional details and impacted files
@@              Coverage Diff               @@
##           main-7.0.x   #10195      +/-   ##
==============================================
- Coverage       82.42%   82.36%   -0.07%     
==============================================
  Files             970      970              
  Lines          274011   274013       +2     
==============================================
- Hits           225858   225687     -171     
- Misses          48153    48326     +173     
Flag Coverage Δ
fuzzcorpus 64.14% <0.00%> (-0.21%) ⬇️
suricata-verify 61.10% <0.00%> (-0.02%) ⬇️
unittests 62.92% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 17616

@victorjulien
Copy link
Member

Merged in #10211, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants