Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

userguide: clarify midstream exception policy - v1 #10198

Closed

Conversation

jufajardini
Copy link
Contributor

The description of behavior when midstream is enabled and exception policy is set to ignore wasn't descriptive enough.

Fix typos.

Link to redmine ticket:
none

@jlucovsky brought to my attention that the description wasn't very good for exception policy ignore when midstream is enabled.

Describe changes:

  • fix typos
  • use a longer description for exception policy ignore when midstream is enabled

The description of behavior when midstream is enabled and exception
policy is set to ignore wasn't descriptive enough.

Fix typos.
@jufajardini jufajardini added the typo/doc update No code change : only doc or typo fixes label Jan 18, 2024
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6896a93) 82.12% compared to head (d14f7b1) 82.14%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10198      +/-   ##
==========================================
+ Coverage   82.12%   82.14%   +0.01%     
==========================================
  Files         975      975              
  Lines      271724   271724              
==========================================
+ Hits       223151   223199      +48     
+ Misses      48573    48525      -48     
Flag Coverage Δ
fuzzcorpus 62.79% <ø> (+0.07%) ⬆️
suricata-verify 61.41% <ø> (-0.01%) ⬇️
unittests 62.83% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@jlucovsky jlucovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@victorjulien victorjulien added this to the 8.0 milestone Jan 19, 2024
@victorjulien
Copy link
Member

Merged in #10204, thanks!

@jufajardini jufajardini deleted the exception-policy-doc-fix/v1 branch January 19, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
typo/doc update No code change : only doc or typo fixes
Development

Successfully merging this pull request may close these issues.

3 participants