detect: allow rule which need both directions to match #10199
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ticket: 5665 This is done with `alert ip any any => any any` The => operator means that we will need both directions
Closed
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #10199 +/- ##
==========================================
+ Coverage 82.12% 82.15% +0.02%
==========================================
Files 975 975
Lines 271724 271777 +53
==========================================
+ Hits 223151 223268 +117
+ Misses 48573 48509 -64
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 17621 |
|
Replaced by #10209 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/5665
Describe changes:
OISF/suricata-verify#1591
Draft: to show POC and get feedback.
Throw me rules examples ! negative and positive...
Maybe this works so far because of tx progress between request and response for HTTP
TODO :
to_clientandto_serverkeywords that are not inflowkeyword, but only apply to a previous keyword)#10194 with
=>