Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport/7.0.x: dpdk: interrupt mode, hugepage analysis, removing old docs' references #10218

Conversation

lukashino
Copy link
Contributor

https://redmine.openinfosecfoundation.org/issues/6697
https://redmine.openinfosecfoundation.org/issues/6696
https://redmine.openinfosecfoundation.org/issues/6699

Describe changes:

  • docs update - remove references to the old versions
  • interrupt mode for DPDK
  • better hugepage analysis

Lukas Sismis added 3 commits January 22, 2024 14:54
Previous integration of hugepage analysis only fetched data
from /proc/meminfo. However this proved to be often
deceiving mainly for providing only global information and
not taking into account different hugepage sizes (e.g. 1GB
hugepages) and different NUMA nodes.

Ticket: OISF#6419
(cherry picked from commit ca6f7c2)
When the packet load is low, Suricata can run in interrupt
mode. This more resembles the classic approach of processing
packets - CPU cores run low and only fetch packets
on interrupt.

Ticket: OISF#5839
(cherry picked from commit 2a28980)
Remove references that are mentioning Suricata 3 or less
As a note - only one Suricata 4 reference found:
(suricata-yaml.rst:"In 4.1.x")
Fast pattern selection criteria can be internally found by inspecting
SupportFastPatternForSigMatchList and SigTableSetup functions.

Ticket: OISF#6570
(cherry picked from commit 6e4cc79)
@lukashino
Copy link
Contributor Author

Note: the Redmine tickets were not officially planned for 7.0.3 but I think it is okay to add it in.

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 17679

@catenacyber
Copy link
Contributor

I think it deserves different PRs for the different issues.

There is one about doc, and the other ones change code for instance...

@victorjulien
Copy link
Member

Agree, please split into separate PRs. Not going to consider the powersaving mode for 7.0.3.

Copy link
Member

@victorjulien victorjulien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline

@lukashino
Copy link
Contributor Author

Okay, thanks all, continues in:
#10225
#10226
#10227

@lukashino lukashino closed this Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants