Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

detect: case-insensitive comparison for requires (7.0.x backport) #10221

Closed
wants to merge 1 commit into from
Closed

detect: case-insensitive comparison for requires (7.0.x backport) #10221

wants to merge 1 commit into from

Conversation

jasonish
Copy link
Member

@catenacyber @jasonish
detect: case-insensitive comparison for requires
c1431c4 
Ticket: 6656
(cherry picked from commit d321838)
@jasonish jasonish mentioned this pull request Jan 22, 2024
Closed
catenacyber
catenacyber approved these changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@catenacyber catenacyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean cherry-pick, good for me

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 17682

@victorjulien victorjulien mentioned this pull request Jan 23, 2024
Closed
@jasonish jasonish closed this Jan 24, 2024
@jasonish jasonish deleted the 7.0.x-requires/v2 branch January 24, 2024 16:31
@victorjulien
Copy link
Member

Can you wait with closing/deleting until after the merge?

@jasonish
Copy link
Member Author

Can you wait with closing/deleting until after the merge?

Oops, bad naming of this branch led to premature garbage collection on my end.

@jasonish jasonish restored the 7.0.x-requires/v2 branch January 24, 2024 18:04
@jasonish jasonish reopened this Jan 24, 2024
@victorjulien victorjulien mentioned this pull request Jan 25, 2024
Merged
@victorjulien
Copy link
Member

Merged in #10253, thanks!

@jasonish jasonish deleted the 7.0.x-requires/v2 branch August 15, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@catenacyber catenacyber catenacyber approved these changes

@victorjulien victorjulien victorjulien approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jasonish @suricata-qa @victorjulien @catenacyber