Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backports/70x/v4 #10223

Closed
wants to merge 2 commits into from
Closed

Backports/70x/v4 #10223

wants to merge 2 commits into from

Conversation

victorjulien
Copy link
Member

2 backports for contributions

glebius and others added 2 commits January 23, 2024 13:33
@glebius @victorjulien
ipfw: close(2) instead shutdown(2) of the divert(4) socket
d5003b3 
The shutdown(2) syscall would always return ENOTCONN for FreeBSD 11,
FreeBSD 12, FreeBSD 13 and FreeBSD 14.  It could do some action on the
socket in the kernel in FreeBSD 10 and before, did not test.

(cherry picked from commit b239e88)
@vincentmli @victorjulien
flow-bypass: Set bypass thread to running state
08d7b55 
When running Suricata in XDP bypass mode (bypass: yes),

Suricata started up with error:
Error: threads: thread "FB" failed to start in time: flags 0003

"FB" thread does not transition from THV_INIT_DONE to THV_RUNNING.

Set "FB" thread THV_RUNNING state in BypassedFlowManager().

Bug: OISF#6254

Signed-off-by: Vincent Li <[email protected]>
(cherry picked from commit f80d26d)
@catenacyber
Copy link
Contributor

Is https://redmine.openinfosecfoundation.org/issues/6254 missing a backport ticket ?

@catenacyber
Copy link
Contributor

Is there a ticket for the ipfw commit ?

@suricata-qa
Copy link

Information:

ERROR: QA failed on SURI_TLPW1_files_sha256.

field baseline test %
SURI_TLPR1_stats_chk
.app_layer.error.http.parser 1108 724 65.34%

Pipeline 17690

@victorjulien
Copy link
Member Author

Is there a ticket for the ipfw commit ?

Don't think so

@catenacyber
Copy link
Contributor

Is there a ticket for the ipfw commit ?

Don't think so

Should there be one to track this ?

@victorjulien victorjulien mentioned this pull request Jan 25, 2024
Merged
@victorjulien
Copy link
Member Author

Merged in #10253, thanks!

@victorjulien victorjulien deleted the backports/70x/v4 branch February 13, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlucovsky jlucovsky jlucovsky approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@victorjulien @catenacyber @suricata-qa @jlucovsky @glebius @vincentmli