requirements: use libhtp 0.5.x #10239
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move to libhtp to the 0.5.x branch instead of 0.5.45.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #10239 +/- ##
==========================================
+ Coverage 82.18% 82.25% +0.06%
==========================================
Files 977 977
Lines 271894 271947 +53
==========================================
+ Hits 223465 223679 +214
+ Misses 48429 48268 -161
Flags with carried forward coverage won't be shown. Click here to find out more. |
victorjulien
approved these changes
Jan 25, 2024
|
This will need to be back ported, right ? |
Indeed |
Merged
|
Merged in #10244, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move to libhtp to the 0.5.x branch instead of 0.5.45.