Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect: allow rule which need both directions to match #10242

Closed
wants to merge 1 commit into from

Conversation

catenacyber
Copy link
Contributor

Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/5665

Describe changes:

  • allows bidirectional signature matching !
SV_BRANCH=pr/1603

OISF/suricata-verify#1603

Not so much a draft anymore...
But I still expect to see next iterations...

TODO :

  • more tests !!!! Throw me rules examples ! negative and positive...
  • think about solution for ambiguous-direction keywords (like new to_client and to_server keywords that are not in flow keyword, but only apply to a previous keyword). Here, it is a documented limitation...

#10231 with

  • fixups
  • adding one field to DetectEngineStateDirection dir_state[] so as to have efficient CPU-time (even if more memory) storage and retrieval of inspect_flags

Ticket: 5665

This is done with `alert ip any any => any any`
The => operator means that we will need both directions
@suricata-qa
Copy link

WARNING:

field baseline test %
build_asan

Pipeline 17744

@catenacyber
Copy link
Contributor Author

Replaced by #10252

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants