detect: respect directionality for filestore #10248
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ticket: 6617 So that rules with keyword like `filestore:to_server,flow` only store the files to server and not the ones to client... Fixes: 79499e4 ("app-layer: move files into transactions")
victorjulien
requested changes
Jan 25, 2024
There was a problem hiding this comment.
I would like to see more of an analysis in the commit, as well as an explanation regarding the flag split per direction.
The explanation is needed as the relationship between defaults, scope and direction are non-obvious, so it's unclear what goes wrong from the commit other than the result is wrong.
Doing in #10251 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/6617
Describe changes:
So that
filestore:to_server,flowonly stores the files to server and not the ones to client...OISF/suricata-verify#1560