Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lua: Move to lua 5.4 and include by default v4 #10255

Closed
wants to merge 6 commits into from

Conversation

J0eJ0h
Copy link
Contributor

@J0eJ0h J0eJ0h commented Jan 25, 2024

Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/4776

Describe changes:

  • Move to using lua 5.4
  • Remove luajit support and --enable-luajit configure option
  • Change --enable-lua option to --disable-lua and build with lua by default

#10238 with:

  • Fixes to PR only CI workflows

Copy link

NOTE: This PR may contain new authors.

Copy link

codecov bot commented Jan 26, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (c3b3c11) 82.28% compared to head (84ff5fb) 81.03%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10255      +/-   ##
==========================================
- Coverage   82.28%   81.03%   -1.26%     
==========================================
  Files         977      992      +15     
  Lines      271950   279505    +7555     
==========================================
+ Hits       223784   226485    +2701     
- Misses      48166    53020    +4854     
Flag Coverage Δ
fuzzcorpus 60.75% <0.00%> (-2.65%) ⬇️
suricata-verify 59.92% <0.00%> (-1.60%) ⬇️
unittests 61.77% <33.33%> (-1.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@jlucovsky jlucovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should lua jit be entirely removed?

git grep luajit returns results from the src directory.

.github/workflows/builds.yml Show resolved Hide resolved
.github/workflows/builds.yml Show resolved Hide resolved
@J0eJ0h
Copy link
Contributor Author

J0eJ0h commented Jan 26, 2024

Should lua jit be entirely removed?

git grep luajit returns results from the src directory.

The remaining instances should just be references to it for rules and flowvars, not the luajit library\code itself.

@J0eJ0h J0eJ0h changed the title lua: Move to lua 5.4 and include by default lua: Move to lua 5.4 and include by default v4 Jan 26, 2024
@J0eJ0h
Copy link
Contributor Author

J0eJ0h commented Jan 26, 2024

Comments addressed in #10263

@J0eJ0h J0eJ0h closed this Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants