-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lua: Move to lua 5.4 and include by default v4 #10255
Conversation
NOTE: This PR may contain new authors. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #10255 +/- ##
==========================================
- Coverage 82.28% 81.03% -1.26%
==========================================
Files 977 992 +15
Lines 271950 279505 +7555
==========================================
+ Hits 223784 226485 +2701
- Misses 48166 53020 +4854
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should lua jit be entirely removed?
git grep luajit
returns results from the src
directory.
The remaining instances should just be references to it for rules and flowvars, not the luajit library\code itself. |
Comments addressed in #10263 |
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/4776
Describe changes:
#10238 with: