Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixups/v1 #10344

Closed
wants to merge 3 commits into from
Closed

Fixups/v1 #10344

wants to merge 3 commits into from

Conversation

victorjulien
Copy link
Member

#10337 and #10340, plus an added error message.

jasonish and others added 3 commits February 8, 2024 13:23
Add not-needed SCCalloc return check to satisfy our Cocci malloc
checks as it can't see that the caller immediately checks the return
value of this simple wrapper around SCCalloc.
Copy link

codecov bot commented Feb 9, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (80abc22) 82.32% compared to head (2582eaa) 82.32%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10344      +/-   ##
==========================================
- Coverage   82.32%   82.32%   -0.01%     
==========================================
  Files         978      978              
  Lines      272142   272147       +5     
==========================================
- Hits       224053   224046       -7     
- Misses      48089    48101      +12     
Flag Coverage Δ
fuzzcorpus 63.59% <14.28%> (-0.01%) ⬇️
suricata-verify 61.47% <14.28%> (-0.03%) ⬇️
unittests 62.83% <14.28%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@victorjulien victorjulien mentioned this pull request Feb 9, 2024
@victorjulien
Copy link
Member Author

replaced by #10345

@victorjulien victorjulien deleted the fixups/v1 branch February 13, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants