Dev 7.0.4/v2 #10350
Merged
Dev 7.0.4/v2 #10350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
inashivb
commented
Feb 9, 2024
inashivb
commented
- start development towards 7.0.4 #10342
- next/280/20240209/v1 #10347 (backported)
As flagged critical by codescan (cherry picked from commit 7f5e98e)
error: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
--> src/dns/log.rs:371:29
|
371 | pub fn dns_print_addr(addr: &Vec<u8>) -> std::string::String {
| ^^^^^^^^ help: change this to: `&[u8]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
(cherry picked from commit 68b0052)
Add not-needed SCCalloc return check to satisfy our Cocci malloc checks as it can't see that the caller immediately checks the return value of this simple wrapper around SCCalloc. (cherry picked from commit f800ed0)
(cherry picked from commit b48ec8a)
(cherry picked from commit 7e4dba7)
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main-7.0.x #10350 +/- ##
===========================================
Coverage 82.25% 82.25%
===========================================
Files 975 975
Lines 274915 274920 +5
===========================================
+ Hits 226128 226140 +12
+ Misses 48787 48780 -7
Flags with carried forward coverage won't be shown. Click here to find out more. |
inashivb
requested review from
victorjulien,
jasonish and
a team
as code owners
|
Information: ERROR: QA failed on SURI_TLPW2_autofp_suri_time. ERROR: QA failed on SURI_TLPR1_suri_time.
Pipeline 18273 |
victorjulien
approved these changes
Feb 9, 2024
|
Merged in #10355, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.