Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect bidir 5665 v8 #10685

Closed
wants to merge 2 commits into from
Closed

Conversation

catenacyber
Copy link
Contributor

Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/5665

Describe changes:

  • allows bidirectional signature matching !
SV_BRANCH=pr/1668

OISF/suricata-verify#1668

Draft again because of second commit
General feedback expected :-)

TODO :

  • Give me better names
  • Where should I document these new keywords bidir.toclient ?
  • set only_ts only if the keyword is ambiguous ?
  • more tests !!!! Throw me rules examples ! negative and positive...
  • think about solution for delaying prefiltering on the toclient direction...

#10506 with needed rebase

Ticket: 5665

This is done with `alert ip any any => any any`
The => operator means that we will need both directions
By using keywords bidir.toclient and bidir.toserver, the following
keywords are forced to the direction even if they can match
on both directions.

Ticket: 5665
@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 19757

@catenacyber
Copy link
Contributor Author

Replaced by #10818

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants