Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

host-info: remove pcre2_substring_list_free use #10780

Closed
wants to merge 1 commit into from

Conversation

victorjulien
Copy link
Member

Function prototype has changed in a recent release. Rather than dealing with detecting that, fall back to our regular pattern of using pcre2_substring_copy_bynumber().

Bug: #6918.
(cherry picked from commit b224209)

Function prototype has changed in a recent release. Rather than dealing
with detecting that, fall back to our regular pattern of using
pcre2_substring_copy_bynumber().

Bug: OISF#6918.
(cherry picked from commit b224209)
Copy link

codecov bot commented Apr 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 82.38%. Comparing base (158018f) to head (79a2cfa).

Additional details and impacted files
@@              Coverage Diff               @@
##           main-7.0.x   #10780      +/-   ##
==============================================
- Coverage       82.46%   82.38%   -0.08%     
==============================================
  Files             976      976              
  Lines          275062   275070       +8     
==============================================
- Hits           226827   226623     -204     
- Misses          48235    48447     +212     
Flag Coverage Δ
fuzzcorpus 63.54% <0.00%> (-0.18%) ⬇️
suricata-verify 61.61% <0.00%> (-0.06%) ⬇️
unittests 62.90% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 19948

Copy link
Contributor

@jufajardini jufajardini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, was a clean cherry-pick, right?

@victorjulien
Copy link
Member Author

Looks good to me, was a clean cherry-pick, right?

Indeed

@victorjulien
Copy link
Member Author

Merged in #10793, thanks!

@victorjulien victorjulien deleted the pcre2-backport/v1 branch June 23, 2024 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants