Detect bidir 5665 v10 #10904
Closed
Detect bidir 5665 v10 #10904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ticket: 5665 This is done with `alert ip any any => any any` The => operator means that we will need both directions
By using keywords bidir.toclient and bidir.toserver, the following keywords are forced to the direction even if they can match on both directions. Ticket: 5665
Do not require a rule to use bidir.toserver after the usage of bidir.toclient for unambiguous keywords, where the rule writer does not want to explicit the redundant direction.
Closed
|
ERROR: ERROR: QA failed on SURI_TLPW1_files_sha256. Pipeline 20203 |
Closed
|
Rebased in #11246 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/5665
Describe changes:
SV_BRANCH=OISF/suricata-verify#1786
Draft again because of second commit
General feedback expected :-)
TODO :
bidir.toclient?#10818 with additional commit to not require unambiguous keyword to specify their direction in the case there was previously some ambiguous keyword with a direction...