Decode runmode/v9 #11233
Closed
Decode runmode/v9 #11233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorjulien
force-pushed
the
decode-runmode/v9
branch
from
5fc7bed to
db306a4
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11233 +/- ##
==========================================
- Coverage 82.52% 77.61% -4.92%
==========================================
Files 938 938
Lines 248297 248152 -145
==========================================
- Hits 204917 192596 -12321
- Misses 43380 55556 +12176
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
ERROR: ERROR: QA failed on SURI_TLPR1_alerts_cmp. Pipeline 20957 |
victorjulien
force-pushed
the
decode-runmode/v9
branch
2 times, most recently
from
4b54286 to
c349bd5
Compare
|
Information: ERROR: QA failed on SURI_TLPR1_suri_time.
Pipeline 21015 |
|
Are you checking the red CI ? |
victorjulien
force-pushed
the
decode-runmode/v9
branch
from
c349bd5 to
03a816d
Compare
- pcap - pcap/file - af-packet - dpdk
victorjulien
force-pushed
the
decode-runmode/v9
branch
from
03a816d to
b5a5f3b
Compare
|
Information: QA ran without warnings. Pipeline 21520 |
victorjulien
force-pushed
the
decode-runmode/v9
branch
from
b5a5f3b to
98d7cac
Compare
|
ERROR: ERROR: QA failed on SURI_TLPW2_autofp_suri_time. Pipeline 21531 |
source-dpdk.c:201:21: warning: Access to field 'dev' results in a dereference of a null pointer (loaded from field 'livedev') [core.NullDereference]
201 | ptv->livedev->dev, rte_strerror(-retval), flush_error.message);
| ^~~~~~~~~~~~~~~~~
./util-debug.h:262:74: note: expanded from macro 'SCLogError'
262 | SCLogErr(SC_LOG_ERROR, __FILE__, __FUNCTION__, __LINE__, _sc_module, __VA_ARGS__)
| ^~~~~~~~~~~
source-dpdk.c:641:17: warning: Potential leak of memory pointed to by 'ptv' [unix.Malloc]
641 | SCReturnInt(TM_ECODE_FAILED);
| ^~~~~~~~~~~~~~~
./util-debug.h:275:48: note: expanded from macro 'SCReturnInt'
275 | #define SCReturnInt(x) return x
| ^
source-dpdk.c:732:67: warning: Access to field 'dev' results in a dereference of a null pointer (loaded from field 'livedev') [core.NullDereference]
732 | SCLogError("%s: error (%s) when getting device info", ptv->livedev->dev,
| ^~~~~~~~~~~~~~~~~
./util-debug.h:262:74: note: expanded from macro 'SCLogError'
262 | SCLogErr(SC_LOG_ERROR, __FILE__, __FUNCTION__, __LINE__, _sc_module, __VA_ARGS__)
| ^~~~~~~~~~~
3 warnings generated.
victorjulien
force-pushed
the
decode-runmode/v9
branch
from
98d7cac to
a29114e
Compare
|
Information: QA ran without warnings. Pipeline 21536 |
|
replaced by #12277 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP branch for merging decoders into capture methods.
https://redmine.openinfosecfoundation.org/issues/6968
Implements it for:
That should show if the approach makes sense and if CI/QA pass.