Template rust keywords 3195 v4 #11911
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ticket: 3195 Also remove unused src/tests/detect-template-buffer.c Completes commit 4a7567b to remove references to template-rust
catenacyber
requested review from
jasonish,
victorjulien and
a team
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11911 +/- ##
==========================================
+ Coverage 82.60% 82.64% +0.04%
==========================================
Files 912 912
Lines 249342 249297 -45
==========================================
+ Hits 205968 206037 +69
+ Misses 43374 43260 -114
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 23057 |
|
Should be rebased after #11916 |
This was referenced Oct 9, 2024
|
Rebased in #11932 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/3195 (generic)
Describe changes:
#11816 with review taken into account
template-rustSV_BRANCH=OISF/suricata-verify#2087