Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect/analyzer: add more details for flow_age - v1 #12011

Closed
wants to merge 1 commit into from

Conversation

AkakiAlice
Copy link
Contributor

@AkakiAlice AkakiAlice commented Oct 22, 2024

Ticket: #6312

Make sure these boxes are checked accordingly before submitting your Pull Request -- thank you.

Contribution style:

Our Contribution agreements:

Changes (if applicable):

Link to ticket: https://redmine.openinfosecfoundation.org/issues/6312

Describe changes:

  • Add more details for the flow.age keyword

Provide values to any of the below to override the defaults.

  • To use an LibHTP, Suricata-Verify or Suricata-Update pull request,
    link to the pull request in the respective _BRANCH variable.
  • Leave unused overrides blank or remove.

SV_BRANCH=OISF/suricata-verify#2103

@jufajardini jufajardini added the outreachy Contributions made by Outreachy applicants label Oct 23, 2024
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.22%. Comparing base (30806ce) to head (4a1f9a3).
Report is 9 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #12011   +/-   ##
=======================================
  Coverage   83.22%   83.22%           
=======================================
  Files         910      910           
  Lines      258136   258146   +10     
=======================================
+ Hits       214831   214849   +18     
+ Misses      43305    43297    -8     
Flag Coverage Δ
fuzzcorpus 61.44% <0.00%> (+0.02%) ⬆️
livemode 19.39% <0.00%> (+<0.01%) ⬆️
pcap 44.44% <0.00%> (-0.02%) ⬇️
suricata-verify 62.74% <100.00%> (-0.01%) ⬇️
unittests 59.28% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@jufajardini jufajardini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks! :)

@victorjulien victorjulien added this to the 8.0 milestone Oct 24, 2024
@victorjulien
Copy link
Member

Merged in #12026, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
outreachy Contributions made by Outreachy applicants
Development

Successfully merging this pull request may close these issues.

3 participants