Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure: Remove obsolete rust support line-v3 #12043

Closed

Conversation

Nancyenos
Copy link
Contributor

@Nancyenos Nancyenos commented Oct 28, 2024

Ticket: #6705

Make sure these boxes are checked accordingly before submitting your Pull Request -- thank you.

Contribution style:

Our Contribution agreements:

Link to ticket: https://redmine.openinfosecfoundation.org/issues/6705

Describe changes:
-remove obsolete rust support line
-Remove the definion enable_rust="yes"
-previous pr #12040

@Nancyenos Nancyenos marked this pull request as ready for review October 28, 2024 10:34
@Nancyenos Nancyenos requested a review from a team as a code owner October 28, 2024 10:34
@jufajardini jufajardini added the outreachy Contributions made by Outreachy applicants label Oct 28, 2024
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.42%. Comparing base (89aa525) to head (31fcf0e).
Report is 70 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #12043   +/-   ##
=======================================
  Coverage   83.42%   83.42%           
=======================================
  Files         910      910           
  Lines      257642   257642           
=======================================
+ Hits       214934   214946   +12     
+ Misses      42708    42696   -12     
Flag Coverage Δ
fuzzcorpus 61.64% <ø> (+0.07%) ⬆️
livemode 19.41% <ø> (-0.01%) ⬇️
pcap 44.40% <ø> (-0.10%) ⬇️
suricata-verify 62.76% <ø> (-0.01%) ⬇️
unittests 59.37% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@catenacyber catenacyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work

CI : ✅
Code : good
Commits segmentation : ok
Commit messages : good
Git ID set : looks fine for me
CLA : you already contributed
Doc update : not needed
Redmine ticket : ok
Rustfmt : no rust
Tests : manually tested ok
Dependencies added: none

@victorjulien victorjulien added this to the 8.0 milestone Nov 28, 2024
@victorjulien
Copy link
Member

Merged in #12178, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
outreachy Contributions made by Outreachy applicants
Development

Successfully merging this pull request may close these issues.

5 participants