detect: log app-layer metadata in alert with single tx #12161
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ticket: 7199 When there is a single transaction, we cannot pick a wrong transaction to log, even if the rule does not use app-layer keywords.
| // if there is a stream match (TCP), or | ||
| // a UDP specific app-layer signature, | ||
| // or only one transaction |
There was a problem hiding this comment.
I think this is a bit vague. The point is that there is only one tx over the lifetime of the flow (so far), so not just one "active" tx. Think the git message can be more clear on this as well.
There was a problem hiding this comment.
I think this code checks if there is one active transaction, not just one over the whole lifetime...
Am I wrong ?
There was a problem hiding this comment.
Fixed this in next version
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12161 +/- ##
==========================================
+ Coverage 49.81% 49.84% +0.03%
==========================================
Files 909 909
Lines 257904 257902 -2
==========================================
+ Hits 128467 128552 +85
+ Misses 129437 129350 -87
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Next in #12166 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/7199
May also solve https://redmine.openinfosecfoundation.org/issues/7406 and https://redmine.openinfosecfoundation.org/issues/7350
Describe changes:
SV_BRANCH=OISF/suricata-verify#2141
Is this the right way to solve most of the cases as I remember discussing with someone ?
#12158 with removing redundant check for pflow->alstate