Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

next/651/70x/20241201/v1 #12188

Merged
merged 3 commits into from
Dec 2, 2024
Merged

next/651/70x/20241201/v1 #12188

merged 3 commits into from
Dec 2, 2024

Conversation

victorjulien
Copy link
Member

satta and others added 3 commits December 1, 2024 07:49
@satta @victorjulien
mqtt: add reason code support for SUBACK
378b9bb 
Ticket: OISF#7323
(cherry picked from commit 377d470)
@jasonish @victorjulien
mqtt: double-check detection directions
552dea9 
Backport of commit 5d82521.

Ticket: 7323
@catenacyber @victorjulien
mqtt: look for a reason code in all messages
1bae761 
instead of stopping on the first message if it does not
have a reason code, like conn and conn_ack

Was fixed in master by big refactor 0a1062f
@codecov Codecov
Copy link

codecov bot commented Dec 1, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.17%. Comparing base (c3a6abf) to head (1bae761).
Report is 3 commits behind head on main-7.0.x.

Additional details and impacted files 
@@              Coverage Diff               @@
##           main-7.0.x   #12188      +/-   ##
==============================================
- Coverage       83.18%   83.17%   -0.01%     
==============================================
  Files             922      922              
  Lines          260821   260845      +24     
==============================================
+ Hits           216953   216966      +13     
- Misses          43868    43879      +11
Flag Coverage Δ
fuzzcorpus 64.15% <84.61%> (+0.02%) ⬆️
suricata-verify 63.35% <100.00%> (+<0.01%) ⬆️
unittests 62.39% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 23618

inashivb
inashivb reviewed Dec 2, 2024
View reviewed changes
Copy link
Member

@inashivb inashivb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@victorjulien victorjulien merged commit 1bae761 into OISF:main-7.0.x Dec 2, 2024
43 of 45 checks passed
@victorjulien victorjulien mentioned this pull request Dec 2, 2024
Closed
@victorjulien victorjulien deleted the next/651/70x/20241201/v1 branch December 2, 2024 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inashivb inashivb inashivb approved these changes

@jasonish jasonish Awaiting requested review from jasonish jasonish is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@victorjulien @suricata-qa @inashivb @satta @jasonish @catenacyber