rust: fix clippy issues #12189
Closed
rust: fix clippy issues #12189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents the clippy warning:
508 | #[derive(FromPrimitive, Debug)]
| ^------------
| |
| `FromPrimitive` is not local
| move the `impl` block outside of this constant `_IMPL_NUM_FromPrimitive_FOR_IsakmpPayloadType`
509 | pub enum IsakmpPayloadType {
| ----------------- `IsakmpPayloadType` is not local
|
= note: the derive macro `FromPrimitive` defines the non-local `impl`, and may need to be changed
= note: the derive macro `FromPrimitive` may come from an old version of the `num_derive` crate, try updating your dependency with `cargo update -p num_derive`
= note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl`
= note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint
= note: this warning originates in the derive macro `FromPrimitive` (in Nightly builds, run with -Z macro-backtrace for more info)
(cherry picked from commit 8e408d3)
Fix provided by cargo clippy --fix. (cherry picked from commit 7bdbe7e)
'///' style rust comments/documentation come before the item being documented. Spotted by clippy. (cherry picked from commit aa6e94f)
But we should fix all these soon. (cherry picked from commit 4c12165)
jlucovsky
requested review from
catenacyber,
victorjulien and
jasonish
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main-7.0.x #12189 +/- ##
==============================================
- Coverage 83.18% 83.16% -0.02%
==============================================
Files 922 922
Lines 260821 260827 +6
==============================================
- Hits 216953 216922 -31
- Misses 43868 43905 +37
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 23619 |
inashivb
reviewed
Dec 2, 2024
Comment on lines
+50
to
+62
| pub struct SCGeneralName<'a>(&'a GeneralName<'a>); | ||
|
|
||
| impl fmt::Display for SCGeneralName<'_> { | ||
| fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result { | ||
| match self.0 { | ||
| GeneralName::DNSName(s) => write!(f, "{}", s), | ||
| GeneralName::URI(s) => write!(f, "{}", s), | ||
| GeneralName::IPAddress(s) => write!(f, "{:?}", s), | ||
| _ => write!(f, "{}", self.0) | ||
| } | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
I think we can skip this and the changes in this file. This was introduced for a feature that does not exist in 7.0.x.
There was a problem hiding this comment.
Thanks. Will make this change.
inashivb
requested changes
Dec 2, 2024
|
Continued in #12201 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #12171
Backport clippy fixes to main-7.0.x