Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect/transforms: in place modifications of buffers #12200

Conversation

catenacyber
Copy link
Contributor

Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/7409

Describe changes:

  • detect/transforms: fix and test in place modifications of buffers (aka do not use memcpy)

#12194 with commit reworded

As is the case when chaining multiple transforms.
Avoids using memcpy in these cases.

Add tests for these cases.

Ticket: 7409
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 98.86364% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.18%. Comparing base (ae10fc3) to head (d205e59).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12200      +/-   ##
==========================================
+ Coverage   83.16%   83.18%   +0.01%     
==========================================
  Files         912      912              
  Lines      257066   257124      +58     
==========================================
+ Hits       213797   213878      +81     
+ Misses      43269    43246      -23     
Flag Coverage Δ
fuzzcorpus 61.01% <72.72%> (+0.03%) ⬆️
livemode 19.41% <0.00%> (-0.01%) ⬇️
pcap 44.41% <24.24%> (-0.01%) ⬇️
suricata-verify 62.78% <90.90%> (+0.07%) ⬆️
unittests 59.18% <93.18%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

WARNING:

field baseline test %
SURI_TLPR1_stats_chk
.http.byterange.memuse 99602115 103910094 104.33%

Pipeline 23628

@victorjulien victorjulien added this to the 8.0 milestone Dec 2, 2024
@victorjulien
Copy link
Member

Merged in #12213, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants