next/653/20241202/v1 #12202
next/653/20241202/v1 #12202
Conversation
For example, "requires: foo bar" is an unknown requirement, however its not tracked, nor an error as it follows the syntax. Instead, record these unknown keywords, and fail the requirements check if any are present. A future version of Suricata may have new requires keywords, for example a check for keywords. Ticket: OISF#7418
To be used by the requires keyword to check for keyword support. Ticket: OISF#7403
For example:
requires: keyword foo;
Will require that Suricata supports the "foo" keyword.
Ticket: OISF#7403
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 4.6.0 to 5.0.7. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@b9fd7d1...015f24e) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.27.0 to 3.27.5. - [Release notes](https://github.com/github/codeql-action/releases) - [Commits](github/codeql-action@v3.27.0...v3.27.5) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
There was a problem hiding this comment.
Consistent with listed PRs...
Is this expected? https://github.com/OISF/suricata/actions/runs/12075846358/job/33676317373#step:24:839
I thought that would have been fixed with #12171, perhaps some generated code needs to be fixed up. Its unrelated to this PR, so I woudln't let it hold this up, and I'll look into right away. |
Wait, that's from another build. Its is not expected anymore. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12202 +/- ##
=======================================
Coverage 83.16% 83.17%
=======================================
Files 912 912
Lines 257066 257111 +45
=======================================
+ Hits 213797 213856 +59
+ Misses 43269 43255 -14
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
WARNING:
Pipeline 23629 |
Staging:
SV_BRANCH=OISF/suricata-verify#2158