rust: fix clippy issues #12220
Closed
rust: fix clippy issues #12220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: none Update cargo and commit the changes
Fix provided by cargo clippy --fix. (cherry picked from commit 7bdbe7e)
'///' style rust comments/documentation come before the item being documented. Spotted by clippy. (cherry picked from commit aa6e94f)
But we should fix all these soon. (cherry picked from commit 4c12165)
jlucovsky
requested review from
catenacyber,
victorjulien and
jasonish
as code owners
victorjulien
reviewed
Dec 4, 2024
| @@ -33,7 +33,7 @@ crc = "~1.8.1" | |||
| lzma-rs = { version = "~0.2.0", features = ["stream"] } | |||
| memchr = "~2.4.1" | |||
| num = "~0.2.1" | |||
| num-derive = "~0.2.5" | |||
| num-derive = "~0.4.2" | |||
There was a problem hiding this comment.
I would expect a cargo lock update to go with this commit
victorjulien
reviewed
Dec 4, 2024
| ] | ||
|
|
||
| [[package]] | ||
| name = "num-derive" | ||
| version = "0.2.5" | ||
| version = "0.4.2" |
There was a problem hiding this comment.
this already has 0.4.2, but it should go before the update?
victorjulien
reviewed
Dec 4, 2024
| @@ -3,10 +3,10 @@ | |||
| version = 3 | |||
There was a problem hiding this comment.
I don't see the point of having 'Issue: none' in the commit message
|
New version at #12223. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #12201
Based on #12171
Backport clippy fixes to main-7.0.x
Description:
Cargo.lockupdate process:(cd rust; cargo update); make; (cd rust; cp Cargo.lock Cargo.lock.in)num-derive-- update version tag inCargo.toml.in