7.0.x: backport treating unknown requirements as unsatisfied with opt-out flag - v1 #12224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example, "requires: foo bar" is an unknown requirement, however its not tracked, nor an error as it follows the syntax. Instead, record these unknown keywords, and fail the requirements check if any are present. A future version of Suricata may have new requires keywords, for example a check for keywords. Ticket: OISF#7418 (cherry picked from commit 820a3e5)
The new behavior in 8, and backported is to treat unknown requirements as unsatisfied requirements. For 7.0.8, add a configuration option, "ignore-unknown-requirements" to completely ignore unknown requirements, effectively treating them as available. Ticket: OISF#7434
jasonish
commented
Dec 4, 2024
| default-rule-path: /var/lib/suricata/rules | ||
| rule-files: | ||
| - suricata.rules | ||
| ignore-unknown-requirements: true |
There was a problem hiding this comment.
I opted for a top-level key to keep it simple, and to keep it close to where you define your rules. The other option would be under detect somewhere.
jasonish
commented
Dec 4, 2024
| @@ -34,6 +34,27 @@ also check all the new features that have been added but are not covered by | |||
| this guide. Those features are either not enabled by default or require | |||
| dedicated new configuration. | |||
|
|
|||
| Upgrading to 7.0.7 | |||
This was referenced Dec 4, 2024
|
Replaced by #12226. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main-7.0.x #12224 +/- ##
==============================================
- Coverage 83.18% 83.17% -0.01%
==============================================
Files 922 922
Lines 260858 260880 +22
==============================================
- Hits 216982 216975 -7
- Misses 43876 43905 +29
Flags with carried forward coverage won't be shown. Click here to find out more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://redmine.openinfosecfoundation.org/issues/7434
SV_BRANCH=OISF/suricata-verify#2162