dpdk: set ice PMD RSS key length to 52 bytes for all DPDK versions #12252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ICE driver (Intel E810 NIC) requires/supports 52-byte long RSS key. The 52 byte key length was mandatory from DPDK 23.11 when Suricata was starting with independently configured ice PMD. However, Suricata failed to start when ice PMD was part of net_bonding PMD, requiring 52 byte RSS key even in DPDK versions lower than 23.11. Since the support for the longer key is present since DPDK 19.11 the key is set to 52 bytes for all versions. Ticket: 7444
victorjulien
approved these changes
Dec 9, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12252 +/- ##
==========================================
+ Coverage 83.18% 83.22% +0.03%
==========================================
Files 912 912
Lines 257174 257173 -1
==========================================
+ Hits 213930 214026 +96
+ Misses 43244 43147 -97
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 23767 |
Merged
|
Merged in #12259, thanks! |
This was referenced Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ICE driver (Intel E810 NIC) requires/supports 52-byte long RSS key. The 52 byte key length was mandatory from DPDK 23.11 when Suricata was starting with independently configured ice PMD.
However, Suricata failed to start when ice PMD was part of net_bonding PMD, requiring 52 byte RSS key even in DPDK versions lower than 23.11. Since the support for the longer key is present since DPDK 19.11 the key is set to 52 bytes for all versions.
https://redmine.openinfosecfoundation.org/issues/7444
Describe changes: