Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Http uri spaces 2881 v19 #9422

Closed
wants to merge 2 commits into from

Conversation

catenacyber
Copy link
Contributor

Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/2881

Describe changes:

  • configures libhtp to allow spaces in URIs

Modifies #8923 with needed rebase

OISF/suricata-verify#1004

SV_BRANCH=pr/1004

@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Merging #9422 (57d8d55) into master (becb8ce) will decrease coverage by 0.03%.
The diff coverage is 80.95%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9422      +/-   ##
==========================================
- Coverage   82.17%   82.14%   -0.03%     
==========================================
  Files         968      968              
  Lines      274198   274219      +21     
==========================================
- Hits       225331   225267      -64     
- Misses      48867    48952      +85     
Flag Coverage Δ
fuzzcorpus 64.04% <76.19%> (+0.01%) ⬆️
suricata-verify 60.87% <80.95%> (-0.01%) ⬇️
unittests 62.88% <19.04%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

ERROR:

ERROR: QA failed on SURI_TLPR1_alerts_cmp.

Pipeline 15779

@catenacyber
Copy link
Contributor Author

catenacyber commented Sep 4, 2023

Additional alerts in QA look an improvement to me (after investigating a bit such a diff)

@victorjulien victorjulien added this to the 8.0 milestone Sep 5, 2023
@catenacyber
Copy link
Contributor Author

Replaced by #9501

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants