runmodes: clear hint when runmode is not indicated v3 #9740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inashivb
reviewed
Nov 4, 2023
| } | ||
|
|
inashivb
requested changes
Nov 4, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #9740 +/- ##
==========================================
- Coverage 82.56% 82.33% -0.23%
==========================================
Files 968 968
Lines 273827 273825 -2
==========================================
- Hits 226074 225450 -624
- Misses 47753 48375 +622
Flags with carried forward coverage won't be shown. Click here to find out more. |
Thank you @inashivb noted. Please for the SV test. Can you give feedback on it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: 5711
Link to redmine ticket:
Describe changes:
Previous PR: #9692
SV_BRANCH=OISF/suricata-verify#1454