🤖 Release PR #3535
Merged
🤖 Release PR #3535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
* feat: deploy firestore rules * feat: pull in rule from PK dev env
* chore: remove non-functional watch * chore: switch to yarn test for consistency * feat: split rules out to target specific collections In preparation for reviewing the permissions around each collection we need to split the matches out to target an individual collection. This allows us to apply rules in a granular fashion, based on the following documented behaviour from Firestore: > It's possible for a document to match more than one match > statement. In the case where multiple allow expressions > match a request, the access is allowed if any of the > conditions is true. https://firebase.google.com/docs/firestore/security/rules-structure#version-1 * test: default to verbose output * test: remove unused plugin/coverage * chore(ci): correct reference to script
1 flaky test on run #5611 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| [Research] > [Create research article] > [By Authenticated] |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #3535 ↗︎
benfurber
approved these changes
May 14, 2024
mariojsnunes
approved these changes
May 15, 2024
|
🎉 This PR is included in version 1.182.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.182.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.