feat: add catergory vertical list to how-tos #4045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benfurber
added
the
Review allow-preview ✅
|
@davehakkens Can be QA'd for how-tos. |
onearmy-community-platform
|
||||||||||||||||||||||||||||
| Project |
onearmy-community-platform
|
| Branch Review |
pull/4045
|
| Run status |
|
| Run duration | 05m 36s |
| Commit |
|
| Committer | Ben Furber |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
2
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
77
|
| View all changes introduced in this branch ↗︎ | |
benfurber
changed the title
|
Actually, I'll keep this PR just to how-tos. |
|
🎉 This PR is included in version 2.19.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
nice component! |
|
@davehakkens Still update through retool. Currently the order is essentially just what's in the database. I was planning to make the order alphabetic in my next PR, does that work for you? Other options:
|
|
alphabetical doesnt do the trick. |
|
And is the category image also added in retool, or a dev-thing? |
|
Dev thing. For ease I updated the existing icon list, it's based on the labels shown above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
What kind of change does this PR introduce?
What is the current behavior?
A SO BORING drop-down to select a category filter for a content type.
What is the new behavior?
All the icons added:
Does this PR introduce a breaking change?
Git Issues
Part of #4003