entrypoint: add docker secret friendly _FILE options #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
to prevent having to define secrets in docker compose file when using docker stack, add a _FILE option for sensitive information so that docker secrets may be used; update README accordingly
andwei
force-pushed
the
docker_secrets
branch
from
4073ce9
to
5e8c212
Compare
|
Yes please. Thank you for creating this commit! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I was deploying the onlyoffice documentserver community edition using docker swarm and thought it would be nice to be able to use docker secrets to avoid putting JWT_SECRET or DB_PWD as environment variables into the compose file. This adds the ability to specify a file, e.g. created from a docker secret, to use as a secret (similar to what mariadb and many other containers do).
Kind regards,
Andreas