Skip to content

Commit

Permalink
change id and remove aria-expanded js from radios
Browse files Browse the repository at this point in the history
  • Loading branch information
rmccar committed Nov 29, 2024
1 parent 004b0f1 commit 2c760e4
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 12 deletions.
16 changes: 8 additions & 8 deletions src/components/radios/example-radios-with-other-checkboxes.njk
Original file line number Diff line number Diff line change
Expand Up @@ -7,21 +7,21 @@
"borderless": true,
"radios": [
{
"id": "post-example-radio-with-other-checkbox-expanded",
"id": "post-example-radio-with-other-checkbox",
"label": {
"text": "By post"
},
"value": "post"
},
{
"id": "email-example-radio-with-other-checkbox-expanded",
"id": "email-example-radio-with-other-checkbox",
"label": {
"text": "By email"
},
"value": "email"
},
{
"id": "phone-example-radio-with-other-checkbox-expanded",
"id": "phone-example-radio-with-other-checkbox",
"label": {
"text": "By phone"
},
Expand All @@ -30,34 +30,34 @@
"other": {
"otherType": "checkboxes",
"selectAllChildren": true,
"id": "phone-time-example-radio-with-other-checkbox-expanded",
"id": "phone-time-example-radio-with-other-checkbox",
"name": "phone-time",
"legend": "Select preferred times of day",
"checkboxes": [
{
"value": "anytime",
"id": "anytime-example-radio-with-other-checkbox-expanded",
"id": "anytime-example-radio-with-other-checkbox",
"label": {
"text": "Anytime of day"
}
},
{
"value": "morning",
"id": "morning-example-radio-with-other-checkbox-expanded",
"id": "morning-example-radio-with-other-checkbox",
"label": {
"text": "Morning"
}
},
{
"value": "afternoon",
"id": "afternoon-example-radio-with-other-checkbox-expanded",
"id": "afternoon-example-radio-with-other-checkbox",
"label": {
"text": "Afternoon"
}
},
{
"value": "evening",
"id": "evening-example-radio-with-other-checkbox-expanded",
"id": "evening-example-radio-with-other-checkbox",
"label": {
"text": "Evening"
}
Expand Down
4 changes: 0 additions & 4 deletions src/components/radios/radios.dom.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,6 @@ domready(async () => {
const radios = [...document.querySelectorAll('.ons-js-radio')];

if (radios.length) {
const Radios = (await import('../checkboxes/checkboxes-with-reveal')).default;

new Radios(radios);

const button = document.querySelector('.ons-js-clear-btn');
const otherInput = document.querySelector('.ons-radio__other');
if (button) {
Expand Down

0 comments on commit 2c760e4

Please sign in to comment.