Skip to content

Commit

Permalink
Remove Line-height in tab component (#3432)
Browse files Browse the repository at this point in the history
Co-authored-by: rmccar <[email protected]>
  • Loading branch information
SriHV and rmccar authored Nov 28, 2024
1 parent d8f4555 commit af2ff28
Show file tree
Hide file tree
Showing 5 changed files with 18 additions and 19 deletions.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
21 changes: 10 additions & 11 deletions src/components/tabs/_tabs.scss
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,10 @@
border-radius: 3px 3px 0 0;
color: var(--ons-color-text);
display: inline-block;
height: 2.55rem;
line-height: 2.25rem;
height: 2.5rem;
margin: 0 0.5rem 0 0;
overflow: visible;
padding: 0 1rem;
padding: 0.25rem 1rem 0.25rem;
position: relative;
text-decoration: underline;

Expand All @@ -62,10 +61,10 @@
background-color: var(--ons-color-focus);
border-bottom: 1px solid var(--ons-color-borders);
box-shadow:
inset 0 0 0 9px var(--ons-color-button-secondary),
inset 17px 0 0 0 var(--ons-color-button-secondary),
inset -17px 0 0 0 var(--ons-color-button-secondary),
inset 0 -13px 0 0 var(--ons-color-text-link-focus);
inset 0 0 0 5px var(--ons-color-button-secondary),
inset 15px 0 0 0 var(--ons-color-button-secondary),
inset -14px 0 0 0 var(--ons-color-button-secondary),
inset 0 -9px 0 0 var(--ons-color-text-link-focus);
color: var(--ons-color-text-link-focus);

// Add transparent outline because Windows High Contrast Mode doesn't show box-shadows
Expand All @@ -88,10 +87,10 @@
&:focus {
background-color: var(--ons-color-focus);
box-shadow:
inset 0 0 0 9px var(--ons-color-page-light),
inset 17px 0 0 0 var(--ons-color-page-light),
inset -17px 0 0 0 var(--ons-color-page-light),
inset 0 -13px 0 0 var(--ons-color-text-link-focus);
inset 0 0 0 5px var(--ons-color-page-light),
inset 15px 0 0 0 var(--ons-color-page-light),
inset -14px 0 0 0 var(--ons-color-page-light),
inset 0 -9px 0 0 var(--ons-color-text-link-focus);
text-decoration: none;
}
}
Expand Down

0 comments on commit af2ff28

Please sign in to comment.