Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertical section navigation active element is a header that behaves like a link #3400

Closed
rmccar opened this issue Oct 10, 2024 · 1 comment · Fixed by #3416
Closed

Vertical section navigation active element is a header that behaves like a link #3400

rmccar opened this issue Oct 10, 2024 · 1 comment · Fixed by #3416
Assignees
Labels
Bug Something isn't working

Comments

@rmccar
Copy link
Contributor

rmccar commented Oct 10, 2024

**Summary
The active page element on the vertical variant of the section navigation component is a header that seems to behave like a link when hovered over with an underline. This needs to be changed so that it is no longer a header, it should be a link like the links to other pages. This will provide a more consistent experience for users as it will behave like the links for other pages.

Expected behaviour
The active page element on the section navigation component should behave like the links to the other pages, should be able to be clicked, focused and when hovered over adds a underline.
See comments from @Majsol

Actual behaviour
The vertical section navigation headers have an underline added when hovered as if they are a link when they aren't and aren't clickable or focusable. As can be seen here on the "section 6" item header.

Screenshots/Examples**
Screenshot 2024-10-10 at 10 20 21

@rmccar rmccar added the Bug Something isn't working label Oct 10, 2024
@MagdalenaLarge MagdalenaLarge added the Refine To be refined label Oct 18, 2024
@Majsol
Copy link

Majsol commented Oct 24, 2024

Richard and I had a chat about this ticket. We have decided to change the functionality of the section header so it behaves like a link even when it is already selected.

@rmccar rmccar changed the title Vertical section navigation header has underline on hover Vertical section navigation active element behaves like a link but is a header Oct 25, 2024
@rmccar rmccar changed the title Vertical section navigation active element behaves like a link but is a header Vertical section navigation active element is a header that behaves like a link Oct 25, 2024
@MagdalenaLarge MagdalenaLarge removed the Refine To be refined label Nov 4, 2024
@admilne admilne self-assigned this Nov 4, 2024
@admilne admilne linked a pull request Nov 6, 2024 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants